Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure only trailing whitespace is trimmed. #407

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Ensure only trailing whitespace is trimmed. #407

merged 1 commit into from
Jun 28, 2024

Conversation

JimBobSquarePants
Copy link
Member

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

Fixes #400

We were not checking the index when trimming entire lines full of whitespace; this meant the entire lines data was incorrectly removed.

We need to preserve full lines to ensure line breaks are laid out correctly.

@JimBobSquarePants JimBobSquarePants merged commit 92a4f32 into main Jun 28, 2024
22 checks passed
@JimBobSquarePants JimBobSquarePants deleted the js/fix-400-whitespace-trim branch June 28, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tocsoft tocsoft tocsoft approved these changes

Assignees
No one assigned
Labels
bug shaping
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TextBuilder.GenerateGlyphs fails with ArgumentOutOfRangeException
2 participants
@JimBobSquarePants @tocsoft